hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Cavallaro (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-6220) PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
Date Tue, 26 Jun 2012 03:06:45 GMT

     [ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Paul Cavallaro updated HBASE-6220:
----------------------------------

    Attachment: ServerMetrics_HBASE_6220.patch

I moved over the metrics that used PersistentMetricsTimeVaryingRate to MetricsHistogram because
it seemed like a better fit. 

No tests are included, but I am looking for feedback for correct approach, and what areas
to test. I could not find any tests that exercised RegionServerMetrics or MasterServerMetrics,
so I did not have much to crib off of.
                
> PersistentMetricsTimeVaryingRate gets used for non-time-based metrics
> ---------------------------------------------------------------------
>
>                 Key: HBASE-6220
>                 URL: https://issues.apache.org/jira/browse/HBASE-6220
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.96.0
>            Reporter: David S. Wang
>            Priority: Minor
>              Labels: noob
>         Attachments: ServerMetrics_HBASE_6220.patch
>
>
> PersistentMetricsTimeVaryingRate gets used for metrics that are not time-based, leading
to confusing names such as "avg_time" for compaction size, etc.  You hav to read the code
in order to understand that this is actually referring to bytes, not seconds.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message