hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4379) [hbck] Does not complain about tables with no end region [Z,]
Date Mon, 25 Jun 2012 11:29:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400426#comment-13400426
] 

Anoop Sam John commented on HBASE-4379:
---------------------------------------

{code}
public boolean checkRegionChain(TableIntegrityErrorHandler handler) throws IOException {
+      // When table is disabled no need to check for the region chain. Some of the regions
+      // accidently if deployed, this below code might report some issues like missing start
+      // or end regions or region hole in chain and may try to fix which is unwanted.
+      if (disabledTables.contains(this.tableName.getBytes())) {
+        return true;
+      }
{code}

When the table is disabled, the regions in this need not undergo the check for consistency
I feel. Suppose a table is disabled and 1st and 3rd regions of it are online. The HBCK will
fix this making the regions offline. But this checkRegionChain can report a hole between the
2 regions and may try to fix this creating a new region. I just added this check at this place.
May be at a broader scope need to add. Pls give you feedback. I will debug more and add changes
if needed.
                
> [hbck] Does not complain about tables with no end region [Z,]
> -------------------------------------------------------------
>
>                 Key: HBASE-4379
>                 URL: https://issues.apache.org/jira/browse/HBASE-4379
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.90.5, 0.92.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 0001-HBASE-4379-hbck-does-not-complain-about-tables-with-.patch,
HBASE-4379_94.patch, hbase-4379.v2.patch
>
>
> hbck does not detect or have an error condition when the last region of a table is missing
(end key != '').

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message