hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6226) move DataBlockEncoding and related classes to hbase-common module
Date Thu, 28 Jun 2012 20:58:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403471#comment-13403471
] 

Hadoop QA commented on HBASE-6226:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12533882/HBASE-6226-v3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2284//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2284//console

This message is automatically generated.
                
> move DataBlockEncoding and related classes to hbase-common module
> -----------------------------------------------------------------
>
>                 Key: HBASE-6226
>                 URL: https://issues.apache.org/jira/browse/HBASE-6226
>             Project: HBase
>          Issue Type: Improvement
>          Components: io, regionserver
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6226-v1.patch, HBASE-6226-v2.patch, HBASE-6226-v3.patch
>
>
> In order to isolate the implementation details of HBASE-4676 (PrefixTrie encoding) and
other DataBlockEncoders by putting them in modules, this pulls up the DataBlockEncoding related
interfaces into hbase-common.
> No tests are moved in this patch.  The only notable change was trimming a few dependencies
on HFileBlock which adds dependencies to much of the regionserver.
> The test suite passes locally for me.
> I tried to keep it as simple as possible... let me know if there are any concerns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message