Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26C4EC78D for ; Thu, 3 May 2012 17:23:11 +0000 (UTC) Received: (qmail 7548 invoked by uid 500); 3 May 2012 17:23:10 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 7516 invoked by uid 500); 3 May 2012 17:23:10 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 7508 invoked by uid 99); 3 May 2012 17:23:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 May 2012 17:23:10 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 May 2012 17:23:09 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id CFA6042EC34 for ; Thu, 3 May 2012 17:22:49 +0000 (UTC) Date: Thu, 3 May 2012 17:22:49 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@hbase.apache.org Message-ID: <817915235.22708.1336065769851.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1975763153.20372.1336018822545.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5923) Cleanup checkAndXXX logic MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267604#comment-13267604 ] Lars Hofhansl commented on HBASE-5923: -------------------------------------- @Stack: You mean have a CompareFilter.CompareOp to o.a.h.h.p.g.ClientProtos.Condition.CompareType mapping? That'd be nice as the client facing interface would not change between 0.94 and trunk. Or have a completely separate CompareOp/CompareType class? > Cleanup checkAndXXX logic > ------------------------- > > Key: HBASE-5923 > URL: https://issues.apache.org/jira/browse/HBASE-5923 > Project: HBase > Issue Type: Improvement > Components: client, regionserver > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Priority: Minor > Fix For: 0.96.0, 0.94.1 > > Attachments: 5923-0.94.txt, 5923-trunk.txt > > > 1. the checkAnd{Put|Delete} method that takes a CompareOP is not exposed via HTable[Interface]. > 2. there is unnecessary duplicate code in the check{Put|Delete} code in HRegionServer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira