Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 31 May 2012 05:36:23 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <670371866.20433.1338442583330.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <1274236501.16303.1337375472382.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-6053) Enhance TestRegionRebalancing test
 to be a system test
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286339#comment-13286339 ] 

stack commented on HBASE-6053:
------------------------------

We already have a fundamental class named ServerManager.  See in master package.  Naming your new class ServerManager will cause confusion.

Why we need ServerManager at all? What does it add that is not in our wrapper scripts starting and stopping servers?  (Why do control up in java rather than in shell scripts w/ easier access to ssh and the shell commands this java script depends on?

The change to TestRegionRebalancing looks good making it a Tool

Whats going on here?

{code}
Index: bin/hbase
===================================================================
--- bin/hbase	(revision 1339959)
+++ bin/hbase	(working copy)
@@ -305,7 +305,7 @@
 
 # Exec unless HBASE_NOEXEC is set.
 if [ "${HBASE_NOEXEC}" != "" ]; then
-  "$JAVA" -XX:OnOutOfMemoryError="kill -9 %p" $JAVA_HEAP_MAX $HBASE_OPTS -classpath "$CLASSPATH" $CLASS "$@"
+  "$JAVA" -Dproc_$COMMAND {-XX:OnOutOfMemoryError="kill -9 %p" $JAVA_HEAP_MAX $HBASE_OPTS -classpath "$CLASSPATH" $CLASS "$@"
 else
-  exec "$JAVA" -XX:OnOutOfMemoryError="kill -9 %p" $JAVA_HEAP_MAX $HBASE_OPTS -classpath "$CLASSPATH" $CLASS "$@"
+  exec "$JAVA" -Dproc_$COMMAND -XX:OnOutOfMemoryError="kill -9 %p" $JAVA_HEAP_MAX $HBASE_OPTS -classpath "$CLASSPATH" $CLASS "$@"
 fi
{code}

Are you going to hunt all system properties for those named w/ a proc_ prefix?

There seems to be a stray { in the line you add above.


> Enhance TestRegionRebalancing test to be a system test
> ------------------------------------------------------
>
>                 Key: HBASE-6053
>                 URL: https://issues.apache.org/jira/browse/HBASE-6053
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>            Priority: Minor
>         Attachments: regionRebalancingSystemTest.txt
>
>
> TestRegionRebalancing can be converted to be a system test

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira