Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8F9BAC78D for ; Thu, 17 May 2012 10:03:28 +0000 (UTC) Received: (qmail 45820 invoked by uid 500); 17 May 2012 10:03:28 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 45611 invoked by uid 500); 17 May 2012 10:03:28 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 45599 invoked by uid 99); 17 May 2012 10:03:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 May 2012 10:03:27 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 May 2012 10:03:26 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 7843C9229 for ; Thu, 17 May 2012 10:03:06 +0000 (UTC) Date: Thu, 17 May 2012 10:03:06 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: <524858399.8121.1337248986494.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1668935946.21895.1336055089462.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5926) Delete the master znode after a master crash MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277696#comment-13277696 ] Hadoop QA commented on HBASE-5926: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527816/5926.v8.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 33 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1909//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1909//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1909//console This message is automatically generated. > Delete the master znode after a master crash > -------------------------------------------- > > Key: HBASE-5926 > URL: https://issues.apache.org/jira/browse/HBASE-5926 > Project: HBase > Issue Type: Improvement > Components: master, scripts > Affects Versions: 0.96.0 > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Fix For: 0.96.0 > > Attachments: 5926.v6.patch, 5926.v8.patch > > > This is the continuation of the work done in HBASE-5844. > But we can't apply exactly the same strategy: for the region server, there is a znode per region server, while for the master & backup master there is a single znode for both. > So if we apply the same strategy as for a regionserver, we may have this scenario: > 1) Master starts > 2) Backup master starts > 3) Master dies > 4) ZK detects it > 5) Backup master receives the update from ZK > 6) Backup master creates the new master node and become the main master > 7) Previous master script continues > 8) Previous master script deletes the master node in ZK > 9) => issue: we deleted the node just created by the new master > This should not happen often (usually the znode will be deleted soon enough), but it can happen. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira