Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 3 May 2012 21:48:49 +0000 (UTC)
From: "jiraposter@reviews.apache.org (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <379906801.24091.1336081729184.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1359178899.35981.1333068447159.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5676) Note that dfs.support.append does
 not have to be enabled post 1.x
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267843#comment-13267843 ] 

jiraposter@reviews.apache.org commented on HBASE-5676:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4999/#review7524
-----------------------------------------------------------


Are you sure this is right? If you're using HBase against Hadoop 1.0, for example, the syncFs() call exists, but sync isn't enabled by default, so this would give you an incorrect result, I'd think

- Todd


On 2012-05-03 21:22:19, David Wang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4999/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-05-03 21:22:19)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Change append checks to sync and hflush checks, in keeping with the spirit of the original code.
bq.  
bq.  Should only be applied to 0.96, as only 0.96 will support Hadoop 1.x+ according to HBASE-5536.
bq.  
bq.  
bq.  This addresses bug HBASE-5676.
bq.      https://issues.apache.org/jira/browse/HBASE-5676
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon 6bc2cf2 
bq.    src/main/java/org/apache/hadoop/hbase/master/MasterStatusServlet.java a0aaaf4 
bq.    src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java 302a3b1 
bq.    src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 3d35d3e 
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java 3ea0a3b 
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java cb7efc3 
bq.    src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java 339a120 
bq.  
bq.  Diff: https://reviews.apache.org/r/4999/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Passed local -PrunAllTests.  Passed test-patch.sh:
bq.  
bq.  
bq.  +1 overall.  
bq.  
bq.      +1 @author.  The patch does not contain any @author tags.
bq.  
bq.      +1 tests included.  The patch appears to include 9 new or modified tests.
bq.  
bq.      +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.
bq.  
bq.      +1 javadoc.  The javadoc tool did not generate any warning messages.
bq.  
bq.      +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
bq.  
bq.      +1 findbugs.  The patch does not introduce any new Findbugs (version ) warnings.
bq.  
bq.      +1 release audit.  The applied patch does not increase the total number of release audit warnings.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  David
bq.  
bq.


> Note that dfs.support.append does not have to be enabled post 1.x
> -----------------------------------------------------------------
>
>                 Key: HBASE-5676
>                 URL: https://issues.apache.org/jira/browse/HBASE-5676
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: 0.96.0
>            Reporter: Eli Collins
>            Assignee: David S. Wang
>         Attachments: HBASE-5676.patch
>
>
> In Hadoop 1.x (HADOOP-8230) we are going to enable durable sync by default, and remove the dfs.support.append option. What this means for you:
> - HBase will work out of the box on Hadoop 1.x, no need to tell people to re-configure
> - You no longer have to enable append (which can result in data loss) to enable HBase support

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira