Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 17 May 2012 22:07:09 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <363661623.11260.1337292429322.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1553746708.24114.1336081850744.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5932) Move RegionServerStatusProtocol
 from ipc package to top-level
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278324#comment-13278324 ] 

Hadoop QA commented on HBASE-5932:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12527925/HBASE-5932.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 32 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1919//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1919//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1919//console

This message is automatically generated.
                
> Move RegionServerStatusProtocol from ipc package to top-level
> -------------------------------------------------------------
>
>                 Key: HBASE-5932
>                 URL: https://issues.apache.org/jira/browse/HBASE-5932
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Trivial
>         Attachments: HBASE-5932.patch
>
>
> From Stack's comment on HBASE-5444:
> We can move the ipc protocol stuff to top level later... I was thinking that these classes shared by master and regionservers could be at o.a.h.h... but can do that later if it makes sense.  Lets get this pb stuff in first.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira