Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8F9A7920F for ; Tue, 8 May 2012 17:50:12 +0000 (UTC) Received: (qmail 2125 invoked by uid 500); 8 May 2012 17:50:12 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 2062 invoked by uid 500); 8 May 2012 17:50:12 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 2054 invoked by uid 99); 8 May 2012 17:50:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 May 2012 17:50:12 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 May 2012 17:50:10 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 1847843AFF6 for ; Tue, 8 May 2012 17:49:49 +0000 (UTC) Date: Tue, 8 May 2012 17:49:49 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: <322930911.39853.1336499389100.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <15577034.30817.1336249192015.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5947) Check for valid user/table/family/qualifier and acl state MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270645#comment-13270645 ] Andrew Purtell commented on HBASE-5947: --------------------------------------- bq. HBase Shell grant/revoke doesn't check for valid user or table/family/qualifier so can you end up having rights for something that doesn't exists. There is an existence check done for the table/family. {code} def grant(user, permissions, table_name, family=nil, qualifier=nil) security_available? # Table should exist raise(ArgumentError, "Can't find a table: #{table_name}") unless exists?(table_name) htd = @admin.getTableDescriptor(table_name.to_java_bytes) if (family != nil) raise(ArgumentError, "Can't find a family: #{family}") unless htd.hasFamily(family.to_java_bytes) end {code} Did you mean this sort of checking is not done at the (Java) API level? How do you suggest to check for the existence of the user? > Check for valid user/table/family/qualifier and acl state > --------------------------------------------------------- > > Key: HBASE-5947 > URL: https://issues.apache.org/jira/browse/HBASE-5947 > Project: HBase > Issue Type: Sub-task > Components: security > Affects Versions: 0.92.1, 0.94.0, 0.96.0 > Reporter: Matteo Bertozzi > Assignee: Matteo Bertozzi > Labels: acl > > HBase Shell grant/revoke doesn't check for valid user or table/family/qualifier so can you end up having rights for something that doesn't exists. > We might also want to ensure, upon table/column creation, that no entries are already stored at the acl table. We might still have residual acl entries if something goes wrong, in postDeleteTable(), postDeleteColumn(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira