Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 7 May 2012 20:22:50 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <28896984.36331.1336422170734.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1172978465.36302.1336421689425.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5952) Sync hardcoded default flush size
 and max file size with hbase-default.xml
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269971#comment-13269971 ] 

Hadoop QA commented on HBASE-5952:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525920/hbase-5952.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1792//console

This message is automatically generated.
                
> Sync hardcoded default flush size and max file size with hbase-default.xml
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5952
>                 URL: https://issues.apache.org/jira/browse/HBASE-5952
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.2
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.92.2
>
>         Attachments: hbase-5952.patch
>
>
> Since the hardcoded default flush size is 64MB, but the default in hbase-default.xml is 128MB, if the client does set it to 64MB,
> the actual flush size will be 128MB instead, due to the way HRegion get the flush size. We can change how HRegion get the flush size,
> but it is clean and simple to sync up the defaults.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira