Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1EAAD91A2 for ; Wed, 23 May 2012 15:44:42 +0000 (UTC) Received: (qmail 3242 invoked by uid 500); 23 May 2012 15:44:41 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 3174 invoked by uid 500); 23 May 2012 15:44:41 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 3033 invoked by uid 99); 23 May 2012 15:44:41 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 May 2012 15:44:41 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 76F29141822 for ; Wed, 23 May 2012 15:44:41 +0000 (UTC) Date: Wed, 23 May 2012 15:44:41 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: <1959270682.11970.1337787881491.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1578036271.14400.1337355786734.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-6050) HLogSplitter renaming recovered.edits and CJ removing the parent directory races, making the HBCK to think cluster is inconsistent. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281680#comment-13281680 ] ramkrishna.s.vasudevan commented on HBASE-6050: ----------------------------------------------- Pls share your comments on this patch? If it is ok i can prepare for other versions also. > HLogSplitter renaming recovered.edits and CJ removing the parent directory races, making the HBCK to think cluster is inconsistent. > ----------------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-6050 > URL: https://issues.apache.org/jira/browse/HBASE-6050 > Project: HBase > Issue Type: Bug > Reporter: ramkrishna.s.vasudevan > Attachments: HBASE-6050.patch > > > The scenario is like this > -> A region is getting splitted. > -> The master is still not processed the split . > -> Region server goes down. > -> Split log manager starts splitting the logs and creates the recovered.edits in the splitlog path. > -> CJ starts and deletes the entry from META and also just completes the deletion of the region dir. > -> in hlogSplitter on final step we rename the recovered.edits to come under the regiondir. > There if the regiondir doesnot exist we tend to create and then add the recovered.edits. > Because of this HBCK thinks it to be an orphan region because we have the regiondir but with no regioninfo. > Ideally cluster is fine but we it is misleading. > {code} > } else { > Path dstdir = dst.getParent(); > if (!fs.exists(dstdir)) { > if (!fs.mkdirs(dstdir)) LOG.warn("mkdir failed on " + dstdir); > } > } > fs.rename(src, dst); > LOG.debug(" moved " + src + " => " + dst); > } else { > LOG.debug("Could not move recovered edits from " + src + > " as it doesn't exist"); > } > } > archiveLogs(null, corruptedLogs, processedLogs, > oldLogDir, fs, conf); > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira