Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 25 May 2012 15:19:23 +0000 (UTC)
From: "Jonathan Hsieh (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1630695786.2582.1337959163530.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <1269894839.4447.1335561888011.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Comment Edited] (HBASE-5892) [hbck] Refactor parallel
 WorkItem* to Futures.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283369#comment-13283369 ] 

Jonathan Hsieh edited comment on HBASE-5892 at 5/25/12 3:19 PM:
----------------------------------------------------------------

Andrew, looks good.  I'm going to wait for the hadoopqa robot to execute the test suite.  Alternately, since this just modifies hbck, can you try this command and share results: 'mvn test -PlocalTests -Dtest=TestHBaseFsck'?

I'd like to keep all hbck across versions essentially the same -- would you be willing to port to 0.90/0.92/0.94?  I'd bet that this may apply to 0.94 and 0.92, and that 0.90 would require some near trivial tweaks. 

                
      was (Author: jmhsieh):
    Andrew, looks good.  I'm going to wait for the hadoopqa robot to execute the test suite.  Alternately, since this just modifies hbck, can you try this command and share results: 'mvn test -PlocalTests -Dtest=TestHbaseFsck'?

I'd like to keep all hbck across versions essentially the same -- would you be willing to port to 0.90/0.92/0.94?  I'd bet that this may apply to 0.94 and 0.92, and that 0.90 would require some near trivial tweaks. 

                  
> [hbck] Refactor parallel WorkItem* to Futures.
> ----------------------------------------------
>
>                 Key: HBASE-5892
>                 URL: https://issues.apache.org/jira/browse/HBASE-5892
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jonathan Hsieh
>            Assignee: Andrew Wang
>              Labels: noob
>         Attachments: hbase-5892.patch
>
>
> This would convert WorkItem* logic (with low level notifies, and rough exception handling)  into a more canonical Futures pattern.
> Currently there are two instances of this pattern (for loading hdfs dirs, for contacting regionservers for assignments, and soon -- for loading hdfs .regioninfo files).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira