Return-Path: 
 <issues-return-47387-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 712FCC0F5
	for <apmail-hbase-issues-archive@www.apache.org>;
 Wed,  9 May 2012 03:07:32 +0000 (UTC)
Received: (qmail 3713 invoked by uid 500); 9 May 2012 03:07:29 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 2185 invoked by uid 500); 9 May 2012 03:07:28 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 1580 invoked by uid 99); 9 May 2012 03:07:26 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 May 2012 03:07:26 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 May 2012 03:07:25 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id D291243B2A6
	for <issues@hbase.apache.org>; Wed,  9 May 2012 03:07:04 +0000 (UTC)
Date: Wed, 9 May 2012 03:07:04 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1483485961.42286.1336532824879.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2012870625.39171.1336490868625.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5957) Mismatch with config param name in
 xml and code
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HBASE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271038#comment-13271038 ] 

Anoop Sam John commented on HBASE-5957:
---------------------------------------

{quote}-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
Change is wrt correcting the xml entry in the hbase-default.xml

{quote}
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.wal.TestHLog
{quote}
Patch has nothing to do with HLog. Failure is not related to this patch I think. Run tests in TestHLog locally and all passed
                
> Mismatch with config param name in xml and code
> -----------------------------------------------
>
>                 Key: HBASE-5957
>                 URL: https://issues.apache.org/jira/browse/HBASE-5957
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Anoop Sam John
>         Attachments: HBASE-5957.patch
>
>
> In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
> {code}
> <property>
>   <name>io.storefile.bloom.cacheonwrite</name>
>   <value>false</value>
>   <description>
> 	  Enables cache-on-write for inline blocks of a compound Bloom filter.
>   </description>
> </property>
> {code}
> No place in the code this config is getting used.
> Instead in CacheConfig there is a config param name 
> {code}
> /**
>    * Configuration key to cache compound bloom filter blocks on write.
>    */
>   public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
>       "hfile.block.bloom.cacheonwrite";
> {code}
> Seems issue with entry in the xml file.
> We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira