Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 30 May 2012 00:56:23 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1423209567.14000.1338339383139.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <1269894839.4447.1335561888011.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem*
 to Futures.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285306#comment-13285306 ] 

Hadoop QA commented on HBASE-5892:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12530128/hbase-5892-2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2042//console

This message is automatically generated.
                
> [hbck] Refactor parallel WorkItem* to Futures.
> ----------------------------------------------
>
>                 Key: HBASE-5892
>                 URL: https://issues.apache.org/jira/browse/HBASE-5892
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jonathan Hsieh
>            Assignee: Andrew Wang
>              Labels: noob
>         Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, hbase-5892-2.patch, hbase-5892.patch
>
>
> This would convert WorkItem* logic (with low level notifies, and rough exception handling)  into a more canonical Futures pattern.
> Currently there are two instances of this pattern (for loading hdfs dirs, for contacting regionservers for assignments, and soon -- for loading hdfs .regioninfo files).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira