Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D178D9E22 for ; Wed, 2 May 2012 17:47:12 +0000 (UTC) Received: (qmail 9015 invoked by uid 500); 2 May 2012 17:47:12 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 8981 invoked by uid 500); 2 May 2012 17:47:12 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 8972 invoked by uid 99); 2 May 2012 17:47:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 May 2012 17:47:12 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 May 2012 17:47:11 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 8D2BC42C1FA for ; Wed, 2 May 2012 17:46:51 +0000 (UTC) Date: Wed, 2 May 2012 17:46:51 +0000 (UTC) From: "Zhihong Yu (JIRA)" To: issues@hbase.apache.org Message-ID: <1415821340.18023.1335980811579.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <319286990.7184.1332491488102.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5625) Avoid byte buffer allocations when reading a value from a Result object MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266753#comment-13266753 ] Zhihong Yu commented on HBASE-5625: ----------------------------------- Will integrate patch v8 in 3 hours if there is no objection. > Avoid byte buffer allocations when reading a value from a Result object > ----------------------------------------------------------------------- > > Key: HBASE-5625 > URL: https://issues.apache.org/jira/browse/HBASE-5625 > Project: HBase > Issue Type: Improvement > Components: client > Affects Versions: 0.92.1 > Reporter: Tudor Scurtu > Assignee: Tudor Scurtu > Labels: patch > Fix For: 0.96.0 > > Attachments: 5625.txt, 5625v2.txt, 5625v3.txt, 5625v4.txt, 5625v5.txt, 5625v6.txt, 5625v7.txt, 5625v8.txt > > > When calling Result.getValue(), an extra dummy KeyValue and its associated underlying byte array are allocated, as well as a persistent buffer that will contain the returned value. > These can be avoided by reusing a static array for the dummy object and by passing a ByteBuffer object as a value destination buffer to the read method. > The current functionality is maintained, and we have added a separate method call stack that employs the described changes. I will provide more details with the patch. > Running tests with a profiler, the reduction of read time seems to be of up to 40%. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira