Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C0F929DA4 for ; Fri, 4 May 2012 01:15:13 +0000 (UTC) Received: (qmail 62994 invoked by uid 500); 4 May 2012 01:15:13 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 62932 invoked by uid 500); 4 May 2012 01:15:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 62924 invoked by uid 99); 4 May 2012 01:15:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2012 01:15:13 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2012 01:15:11 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 37E6642F327 for ; Fri, 4 May 2012 01:14:50 +0000 (UTC) Date: Fri, 4 May 2012 01:14:50 +0000 (UTC) From: "Phabricator (JIRA)" To: issues@hbase.apache.org Message-ID: <1379655438.24959.1336094090230.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1493578728.4919.1330550759114.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5494) Introduce a zk hosted table-wide read/write lock so only one table operation at a time MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268007#comment-13268007 ] Phabricator commented on HBASE-5494: ------------------------------------ avf has commented on the revision "[jira] [HBASE-5494] [89-fb] Table-level locks for schema changing operations.". @stack I'm currently thinking over this. I think it makes sense to have a separate JIRA (or perhaps another patch for the same JIRA?) to address this -- acquiring a table lock for merges and splits makes sense to me. Since a table lock would only serve to prevent table schema modifications (disabling/enabling schemas), it would be okay if the lock remains "stuck" during a split -- as long as there is a way to recover from this. I am thinking of the right way to remove persistent locks in general from a crash -- will get back to you with some thoughts on the matter. REVISION DETAIL https://reviews.facebook.net/D2997 > Introduce a zk hosted table-wide read/write lock so only one table operation at a time > -------------------------------------------------------------------------------------- > > Key: HBASE-5494 > URL: https://issues.apache.org/jira/browse/HBASE-5494 > Project: HBase > Issue Type: Improvement > Reporter: stack > Attachments: D2997.3.patch > > > I saw this facility over in the accumulo code base. > Currently we just try to sort out the mess when splits come in during an online schema edit; somehow we figure we can figure all possible region transition combinations and make the right call. > We could try and narrow the number of combinations by taking out a zk table lock when doing table operations. > For example, on split or merge, we could take a read-only lock meaning the table can't be disabled while these are running. > We could then take a write only lock if we want to ensure the table doesn't change while disabling or enabling process is happening. > Shouldn't be too hard to add. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira