hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6032) Port HFileBlockIndex improvement from HBASE-5987
Date Fri, 25 May 2012 04:00:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283098#comment-13283098
] 

Hadoop QA commented on HBASE-6032:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12529563/6032-ports-5987.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 15 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 36 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1992//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1992//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1992//console

This message is automatically generated.
                
> Port HFileBlockIndex improvement from HBASE-5987
> ------------------------------------------------
>
>                 Key: HBASE-6032
>                 URL: https://issues.apache.org/jira/browse/HBASE-6032
>             Project: HBase
>          Issue Type: Task
>            Reporter: Zhihong Yu
>         Attachments: 6032-ports-5987.txt
>
>
> Excerpt from HBASE-5987:
> First, we propose to lookahead for one more block index so that the HFileScanner would
know the start key value of next data block. So if the target key value for the scan(reSeekTo)
is "smaller" than that start kv of next data block, it means the target key value has a very
high possibility in the current data block (if not in current data block, then the start kv
of next data block should be returned. +Indexing on the start key has some defects here+)
and it shall NOT query the HFileBlockIndex in this case. On the contrary, if the target key
value is "bigger", then it shall query the HFileBlockIndex. This improvement shall help to
reduce the hotness of HFileBlockIndex and avoid some unnecessary IdLock Contention or Index
Block Cache lookup.
> This JIRA is to port the fix to HBase trunk, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message