hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5295) Improve the Thrift API to switch on/off writing to wal for Mutations
Date Fri, 04 May 2012 21:33:57 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268724#comment-13268724
] 

Phabricator commented on HBASE-5295:
------------------------------------

Kannan has commented on the revision "[jira] [HBASE-5295] [89-fb] Improve the Thrift API to
switch on/off writing to wal for Mutations".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:989 @mikhail: the tighter
check you added to make sure all mutations have the same writeToWAL setting should be added
for this case too.

  Otherwise, rest of the diff looks really good. And nice test!

REVISION DETAIL
  https://reviews.facebook.net/D3015

                
> Improve the Thrift API  to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
>                 Key: HBASE-5295
>                 URL: https://issues.apache.org/jira/browse/HBASE-5295
>             Project: HBase
>          Issue Type: Improvement
>          Components: thrift
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch,
D1515.2.patch, D1515.2.patch, D1515.2.patch, D3015.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes.
Support it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message