hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5959) Add other load balancers
Date Tue, 29 May 2012 22:21:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285189#comment-13285189
] 

Elliott Clark commented on HBASE-5959:
--------------------------------------

bq. Why does RegionPlanComparator implemenent Serializable?

Findbugs wants it so that any collection using this can also be serializable.  Probably not
needed but trying to correct findbugs where I can.

bq. Maybe doc why you are doing this compare on regionid... are you dependent on it being
timestamp?
bq. Why not do 'return r.getRegionInfo().getRegionId() - l.getRegionInfo().getRegionId();'
rather than check < 0 and return -1, etc?

These are both just moved code from the old balancer.   My bet would be the comparator was
written that way so the return works without a type cast and if the diff is greater than an
int can hold.  But not sure.

bq. Should RegionPlanComparator be public? Could it be package private? It needs to be public
so the balancer package has access?

Yep it needs to be used by the balancer package.

bq. Comment seems wrong '+ // The cache for where load balancers are located.'

bq. This is an expensive call? computeHDFSBlocksDistribution? Goes to NN? We do it for every
region in cluster every time we balance? We doing to DOS the NN?

We do this for every region.  However we cache this for a given amount of time.  Should we
up that beyond 30 mins ?

bq. Why ServerAndLoad implement Serializable? You planning on java serializing it?

Another findbugs special

bq. Does StochasticLoadBalancer have to be a public class?

It makes the factory much easier.  Not 100% required but makes it use less reflection to create
an instance.
                
> Add other load balancers
> ------------------------
>
>                 Key: HBASE-5959
>                 URL: https://issues.apache.org/jira/browse/HBASE-5959
>             Project: HBase
>          Issue Type: New Feature
>          Components: master
>    Affects Versions: 0.96.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HBASE-5959-0.patch, HBASE-5959-1.patch, HBASE-5959-11.patch, HBASE-5959-2.patch,
HBASE-5959-3.patch, HBASE-5959-6.patch, HBASE-5959-7.patch, HBASE-5959-8.patch, HBASE-5959-9.patch,
HBASE-5959.D3189.1.patch, HBASE-5959.D3189.2.patch, HBASE-5959.D3189.3.patch, HBASE-5959.D3189.4.patch,
HBASE-5959.D3189.5.patch, HBASE-5959.D3189.6.patch, HBASE-5959.D3189.7.patch
>
>
> Now that balancers are pluggable we should give some options.b

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message