hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
Date Wed, 16 May 2012 18:45:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277010#comment-13277010
] 

Zhihong Yu commented on HBASE-6002:
-----------------------------------

The same construct is used for both places when closing writer:
{code}
+              try {
+                wap.w.close();
+              } catch (IOException e) {
{code}
If the first close encountered some IOE, calling it the second time would most likely encounter
similar error.
My comment @ 15/May/12 21:25 applies in the above scenario.
                
> Possible chance of resource leak in HlogSplitter
> ------------------------------------------------
>
>                 Key: HBASE-6002
>                 URL: https://issues.apache.org/jira/browse/HBASE-6002
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 0.94.0, 0.96.0
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch
>
>
> In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop
while closing the writers(wap.w) if any exception comes other writers won't close.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message