hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Nyman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5533) Add more metrics to HBase
Date Sat, 26 May 2012 06:43:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283920#comment-13283920
] 

Ted Nyman commented on HBASE-5533:
----------------------------------

Unless I'm missing something (and I hope I am), this addition is completely without proper
attribution. The code is copied virtually line for line from Coda Hale's metrics library,
in particuar: https://github.com/codahale/metrics/tree/master/metrics-core/src/main/java/com/yammer/metrics/stats.
This is the exact same implementation (even comments) as in https://github.com/apache/hbase/tree/trunk/src/main/java/org/apache/hadoop/hbase/metrics/histogram.
There is no credit in hbase license, inline comments, or in the source code itself. 
                
> Add more metrics to HBase
> -------------------------
>
>                 Key: HBASE-5533
>                 URL: https://issues.apache.org/jira/browse/HBASE-5533
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.92.2, 0.94.0
>            Reporter: Shaneal Manek
>            Assignee: Shaneal Manek
>            Priority: Minor
>             Fix For: 0.92.2, 0.94.0, 0.96.0
>
>         Attachments: BlockingQueueContention.java, HBASE-5533-0.92-v4.patch, HBASE-5533-TRUNK-v6.patch,
HBASE-5533-TRUNK-v6.patch, HBASE-5533-v7-0.92.patch, TimingOverhead.java, hbase-5533-0.92.patch,
hbase5533-0.92-v2.patch, hbase5533-0.92-v3.patch, hbase5533-0.92-v5.patch, histogram_web_ui.png
>
>
> To debug/monitor production clusters, there are some more metrics I wish I had available.
> In particular:
> - Although the average FS latencies are useful, a 'histogram' of recent latencies (90%
of reads completed in under 100ms, 99% in under 200ms, etc) would be more useful
> - Similar histograms of latencies on common operations (GET, PUT, DELETE) would be useful
> - Counting the number of accesses to each region to detect hotspotting
> - Exposing the current number of HLog files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message