hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5945) Reduce buffer copies in IPC server response path
Date Sun, 06 May 2012 13:09:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269213#comment-13269213
] 

Todd Lipcon commented on HBASE-5945:
------------------------------------

Yep, I think the next improvement is to use thread-local or connection-local buffers - perhaps
even direct buffers. There's still one more copy from the heap byte buffer to a direct buffer
within the SocketChannel.write() which would be avoided if we serialized directly into a DirectByteBuffer.
Have to benchmark whether that's worth it.

We should also do the same hacks on the client side of the connection - should get similar
gains.
                
> Reduce buffer copies in IPC server response path
> ------------------------------------------------
>
>                 Key: HBASE-5945
>                 URL: https://issues.apache.org/jira/browse/HBASE-5945
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: buffer-copies.txt, even-fewer-copies.txt
>
>
> The new PB code is sloppy with buffers and makes several needless copies. This increases
GC time a lot. A few simple changes can cut this back down.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message