hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5935) Add Region-level PB-based calls to HMasterInterface
Date Tue, 08 May 2012 03:12:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270156#comment-13270156
] 

jiraposter@reviews.apache.org commented on HBASE-5935:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5060/#review7664
-----------------------------------------------------------


Looks good to me.


src/main/protobuf/Master.proto
<https://reviews.apache.org/r/5060/#comment16877>

    Probably we don't need to specify default = false here, right?


- Jimmy


On 2012-05-08 01:34:20, Gregory Chanan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/5060/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-05-08 01:34:20)
bq.  
bq.  
bq.  Review request for hbase, Michael Stack and Jimmy Xiang.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign,
unassign).
bq.  
bq.  I've put the new generated calls in HMasterInterface rather than a new class, because
it is easier to have one class for now, until I convert everything.  This will only be temporary,
but let me know how you want to handle.  Bump the version number?
bq.  
bq.  
bq.  This addresses bug HBASE-5935.
bq.      https://issues.apache.org/jira/browse/HBASE-5935
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547 
bq.    src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119 
bq.    src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f 
bq.    src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1 
bq.    src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION

bq.    src/main/protobuf/Master.proto PRE-CREATION 
bq.    src/main/protobuf/RegionServerStatus.proto 9d7728f 
bq.    src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603 
bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc 
bq.  
bq.  Diff: https://reviews.apache.org/r/5060/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Gregory
bq.  
bq.


                
> Add Region-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
>                 Key: HBASE-5935
>                 URL: https://issues.apache.org/jira/browse/HBASE-5935
>             Project: HBase
>          Issue Type: Task
>          Components: ipc, master, migration
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>             Fix For: 0.96.0
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make
this a subtask (apparently).
> This is for converting the region-level calls, i.e.:
> moveRegion
> assignRegion
> unassignRegion

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message