hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6110) Fix TestInfoServers
Date Sun, 27 May 2012 17:53:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284191#comment-13284191
] 

Jesse Yates commented on HBASE-6110:
------------------------------------

Back to the real issue, it seems like a concurrency bug, like surefire isn't doing the right
then when parallelizing the tests. There is the fork factor of 4 (perThread and then threads
set to 4). Originally, this was done in HBASE-5064; I'm surprised that we didn't break things
there. Conceptually, the parallelization shouldn't work unless we get consistently lucky with
test order - the minicluster will have problems if it can't find the right port, which it
shouldn't if another jvm is also running a mini-cluster.

The this wouldn't be a big issue except that the master goes down if the http server port
is already taken:
{quote}
java.net.BindException: Address already in use
	at sun.nio.ch.Net.bind(Native Method)
	at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:126)
	at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:59)
	at org.mortbay.jetty.nio.SelectChannelConnector.open(SelectChannelConnector.java:216)
	at org.apache.hadoop.http.HttpServer.start(HttpServer.java:581)
	at org.apache.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:929)
	at org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:585)
	at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:386)
	at java.lang.Thread.run(Thread.java:680)
{quote}

Should this be the case? I feel like hbasetestutility's minicluster should have the webui
off by default, unless otherwise desired (I tend to turn it off in the tests I write, just
to speed things up). Also, if the webui is taken, it should just bump the port number to the
next available.

Thoughts?
                
> Fix TestInfoServers
> -------------------
>
>                 Key: HBASE-6110
>                 URL: https://issues.apache.org/jira/browse/HBASE-6110
>             Project: HBase
>          Issue Type: Bug
>          Components: build, master, regionserver
>    Affects Versions: 0.96.0
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>         Attachments: hbase-6110-v0.patch, hbase-6110-v1.patch
>
>
> With the recent port to modules, we broke a couple of tests, including this one. The
fix needs to ensure that the webapp still works from the in-situ and packaged running of HBase.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message