hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5992) Generalization of region move implementation + manage draining servers in bulk assign
Date Fri, 11 May 2012 23:13:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273708#comment-13273708
] 

Zhihong Yu commented on HBASE-5992:
-----------------------------------

{code}
-    this.servers.entrySet();
+    this.servers.entrySet();   // todo: ?? very smart or copy paste error
{code}
Can we remove the above statement ?

In HMaster.java:
{code}
+        if (this.cpHost.preMove( hri , rp.getSource(), rp.getDestination())) {
{code}
Please remove the spaces around hri - minor.
{code}
+   * Creates a list of possible destination for a region. It contains the online servers,
but not
{code}
'destination' -> 'destinations'
{code}
+  public List<ServerName> createDestinationServersList(){
{code}
Please add javadoc for the method above.
                
> Generalization of region move implementation + manage draining servers in bulk assign
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-5992
>                 URL: https://issues.apache.org/jira/browse/HBASE-5992
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 5992.v2.patch
>
>
> The region move implementation now has now a similar behavior whatever the destination
server is specified or not. This allows:
>  - to benefit from the improvement in HBASE-5877
>  - as a side effect to have the coprocessors calls when the destination server is not
specified
>  
> This includes various fixes around draining servers. Draining servers were not excluded
during a bulk assign. This is now fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message