hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5444) Add PB-based calls to HMasterRegionInterface
Date Tue, 01 May 2012 01:30:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265585#comment-13265585
] 

jiraposter@reviews.apache.org commented on HBASE-5444:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4463/
-----------------------------------------------------------

(Updated 2012-05-01 01:29:14.986766)


Review request for hbase and Michael Stack.


Summary
-------

Adds PB-based calls replacing HMasterRegionInterface.

There are some temporary hacks, e.g. converting PB-based ServerLoad to existing HServerLoad
so I didn't need to convert ClusterStatus (which brings in a lot of other changes).  That
will be cleaned up in HBASE-5445.


This addresses bug HBASE-5444.
    https://issues.apache.org/jira/browse/HBASE-5444


Diffs
-----

  src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon 69434f7 
  src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon 3c7c091 
  src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 5d7f07b 
  src/main/java/org/apache/hadoop/hbase/HConstants.java a9d80a0 
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 0db2760 
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 973c7cb 
  src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java fd97830 
  src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java bb6ab3b 
  src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java f56127d 
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java 81e9023 
  src/main/java/org/apache/hadoop/hbase/master/MXBean.java 7f44dc2 
  src/main/java/org/apache/hadoop/hbase/master/MXBeanImpl.java 45b8fe7 
  src/main/java/org/apache/hadoop/hbase/master/MasterDumpServlet.java be63838 
  src/main/java/org/apache/hadoop/hbase/master/RegionServerStatusProtocol.java PRE-CREATION

  src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 80271b1 
  src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java 994cb76 
  src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java efcf74d 
  src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionServerStatusProtos.java PRE-CREATION

  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ebffad6 
  src/main/protobuf/RegionServerStatus.proto PRE-CREATION 
  src/main/protobuf/hbase.proto 12e6053 
  src/main/resources/hbase-webapps/master/table.jsp 3ef1190 
  src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 72554cb 
  src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java d039be3 
  src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 36046f8 
  src/test/java/org/apache/hadoop/hbase/master/TestMXBean.java bd5fa90 
  src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java f8029ba 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java e99d251


Diff: https://reviews.apache.org/r/4463/diff


Testing
-------

Ran jenkins job, all unit tests passed.


Thanks,

Gregory


                
> Add PB-based calls to HMasterRegionInterface
> --------------------------------------------
>
>                 Key: HBASE-5444
>                 URL: https://issues.apache.org/jira/browse/HBASE-5444
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Todd Lipcon
>            Assignee: Gregory Chanan
>         Attachments: HBASE-5444-v6-trunk.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message