hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Bautin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock
Date Thu, 10 May 2012 18:00:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272561#comment-13272561
] 

Mikhail Bautin commented on HBASE-5898:
---------------------------------------

Is there any way to avoid messing up cache hit ratio with these optimizations? Maybe pass
a flag to getBlock saying we should not update the metrics.

Another suggestion from Kannan: maybe we should move metric updates and other extra logic
outside of the lock, and only leave cache lookup and HDFS I/O inside the lock.
                
> Consider double-checked locking for block cache lock
> ----------------------------------------------------
>
>                 Key: HBASE-5898
>                 URL: https://issues.apache.org/jira/browse/HBASE-5898
>             Project: HBase
>          Issue Type: Improvement
>          Components: performance
>    Affects Versions: 0.94.1
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: 5898-TestBlocksRead.txt, hbase-5898.txt
>
>
> Running a workload with a high query rate against a dataset that fits in cache, I saw
a lot of CPU being used in IdLock.getLockEntry, being called by HFileReaderV2.readBlock. Even
though it was all cache hits, it was wasting a lot of CPU doing lock management here. I wrote
a quick patch to switch to a double-checked locking and it improved throughput substantially
for this workload.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message