hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5676) Note that dfs.support.append does not have to be enabled post 1.x
Date Thu, 03 May 2012 21:22:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267808#comment-13267808
] 

jiraposter@reviews.apache.org commented on HBASE-5676:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4999/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

Change append checks to sync and hflush checks, in keeping with the spirit of the original
code.

Should only be applied to 0.96, as only 0.96 will support Hadoop 1.x+ according to HBASE-5536.


This addresses bug HBASE-5676.
    https://issues.apache.org/jira/browse/HBASE-5676


Diffs
-----

  src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon 6bc2cf2 
  src/main/java/org/apache/hadoop/hbase/master/MasterStatusServlet.java a0aaaf4 
  src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java 302a3b1 
  src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 3d35d3e 
  src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java 3ea0a3b 
  src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java cb7efc3 
  src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java 339a120 

Diff: https://reviews.apache.org/r/4999/diff


Testing
-------

Passed local -PrunAllTests.  Passed test-patch.sh:


+1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version ) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.


Thanks,

David


                
> Note that dfs.support.append does not have to be enabled post 1.x
> -----------------------------------------------------------------
>
>                 Key: HBASE-5676
>                 URL: https://issues.apache.org/jira/browse/HBASE-5676
>             Project: HBase
>          Issue Type: Task
>            Reporter: Eli Collins
>            Assignee: David S. Wang
>
> In Hadoop 1.x (HADOOP-8230) we are going to enable durable sync by default, and remove
the dfs.support.append option. What this means for you:
> - HBase will work out of the box on Hadoop 1.x, no need to tell people to re-configure
> - You no longer have to enable append (which can result in data loss) to enable HBase
support

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message