hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5901) Use union type protobufs instead of class/byte pairs for multi requests
Date Tue, 01 May 2012 22:26:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266202#comment-13266202
] 

Hadoop QA commented on HBASE-5901:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525223/hbase-5901.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestFromClientSide
                  org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1712//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1712//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1712//console

This message is automatically generated.
                
> Use union type protobufs instead of class/byte pairs for multi requests
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5901
>                 URL: https://issues.apache.org/jira/browse/HBASE-5901
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc, performance
>    Affects Versions: 0.96.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hbase-5901.txt, hbase-5901.txt
>
>
> The current implementation of multi actions uses repeated "NameBytesPair"s for the contents
of multi actions. Instead, we should introduce a union type protobuf for the valid actions.
This makes the RPCs smaller since they don't need to carry class names, and makes deserialization
faster since it can avoid some copying and reflection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message