hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-5942) HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
Date Tue, 08 May 2012 19:33:54 GMT

     [ https://issues.apache.org/jira/browse/HBASE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-5942:
-------------------------

    Assignee: ramkrishna.s.vasudevan
      Status: Patch Available  (was: Open)

lgtm

Trying against hadoopqa
                
> HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-5942
>                 URL: https://issues.apache.org/jira/browse/HBASE-5942
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.1
>            Reporter: Zhihong Yu
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: hbase-5942.patch
>
>
> HConnnectionManager.getRegionServerWithRetries:
> {code}
>           return callable.call();
>         } catch (Throwable t) {
>           callable.shouldRetry(t);
> {code}
> shouldRetry relies on the proper startTime and endTime to calculate the timeout value.
However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be
set to negative value in callable.shouldRetry().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message