hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5918) Master will block forever when startup if root server died between assign root and assign meta
Date Thu, 03 May 2012 05:16:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267187#comment-13267187
] 

stack commented on HBASE-5918:
------------------------------

Shouldn't we remove the setting of this flag that happens later in finishInitialization?

+1 on the patch otherwise.  This is good stuff.

Any chance of a test?  It looks like it'd be hard to get one in here but it be good if you
fellas at least said why a test is hard to squeeze in here to show you at least tried figuring
how to test this stuff.  The flag disabling shutdown handler was only added recently but here
we find an issue w/ it already.

{code}
Author: Michael Stack <stack@apache.org>  2012-03-13 08:35:54
Committer: Michael Stack <stack@apache.org>  2012-03-13 08:35:54
Parent: fbd4bebd5cca129f49e91ec9936f604998a7025a (HBASE-5314 racefully rolling restart region
servers in rolling-restart.sh)
Child:  59e5460807a1dc0fb5763e4b12dda4be49ef3bb4 (HBASE-5574 DEFAULT_MAX_FILE_SIZE defaults
to a negative value)
Branches: 094.testfail, 5833trunk, hanging, pbwork, remotes/origin/instant_schema_alter, remotes/origin/trunk,
v10, v4, v6
Follows: 
Precedes: 

    HBASE-5179 Handle potential data loss due to concurrent processing of processFaileOver
and ServerShutdownHandler
    
    git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1300194 13f79535-47bb-0310-9956-ffa450edef68

----- src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java -----
inde
{code}

                
> Master will block forever when startup if root server died between assign root and assign
meta
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5918
>                 URL: https://issues.apache.org/jira/browse/HBASE-5918
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.92.1
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>         Attachments: HBASE-5918.patch, HBASE-5918.patch
>
>
> When master is initializing, if root server died between assign root and assign meta,
master will block at 
> HMaster#assignRootAndMeta:{code}assignmentManager.assignMeta();
> this.catalogTracker.waitForMeta();{code}
> because ServerShutdownHandler is disabled,
> So we should enable ServerShutdownHandler after called assignmentManager.assignMeta();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message