hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5867) Improve Compaction Throttle Default
Date Fri, 04 May 2012 16:46:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268522#comment-13268522

Hadoop QA commented on HBASE-5867:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

     -1 core tests.  The patch failed these unit tests:

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1764//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1764//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1764//console

This message is automatically generated.
> Improve Compaction Throttle Default
> -----------------------------------
>                 Key: HBASE-5867
>                 URL: https://issues.apache.org/jira/browse/HBASE-5867
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>         Attachments: D2943.1.patch, HBASE-5867-trunk.patch
> We recently had a production issue where our compactions fell behind because our compaction
throttle was improperly tuned and accidentally upgraded all compactions to the large pool.
 The default from HBASE-3877 makes 1 bad assumption: the default number of flushed files in
a compaction.  Currently the algorithm is:
> throttleSize ~= flushSize * 2
> This assumes that the basic compaction utilizes 3 files and that all 3 files are compressed.
 In this case, "hbase.hstore.compaction.min" == 6 && the values were not very compressible.
 Both conditions should be taken into consideration.  As a default, it is less damaging for
the large thread to be slightly higher than it needs to be versus having everything accidentally

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message