hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5958) Replace ByteString.copyFrom with new ByteString()
Date Tue, 15 May 2012 17:30:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276021#comment-13276021
] 

Todd Lipcon commented on HBASE-5958:
------------------------------------

Makes me nervous to reach in and use the private constructor... do you have some benchmarks
that show that there's a noticeable speedup by doing so?
                
> Replace ByteString.copyFrom with new ByteString()
> -------------------------------------------------
>
>                 Key: HBASE-5958
>                 URL: https://issues.apache.org/jira/browse/HBASE-5958
>             Project: HBase
>          Issue Type: Improvement
>          Components: performance
>    Affects Versions: 0.96.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>
> ByteString.copyFrom makes a copy of a byte array in case it is changed in other thread.
> In most case, we don't need to worry about that.  We should avoid copying the bytes
> for performance issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message