hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5957) Mismatch with config param name in xml and code
Date Wed, 09 May 2012 03:07:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271038#comment-13271038
] 

Anoop Sam John commented on HBASE-5957:
---------------------------------------

{quote}-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
Change is wrt correcting the xml entry in the hbase-default.xml

{quote}
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.wal.TestHLog
{quote}
Patch has nothing to do with HLog. Failure is not related to this patch I think. Run tests
in TestHLog locally and all passed
                
> Mismatch with config param name in xml and code
> -----------------------------------------------
>
>                 Key: HBASE-5957
>                 URL: https://issues.apache.org/jira/browse/HBASE-5957
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Anoop Sam John
>         Attachments: HBASE-5957.patch
>
>
> In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"
> {code}
> <property>
>   <name>io.storefile.bloom.cacheonwrite</name>
>   <value>false</value>
>   <description>
> 	  Enables cache-on-write for inline blocks of a compound Bloom filter.
>   </description>
> </property>
> {code}
> No place in the code this config is getting used.
> Instead in CacheConfig there is a config param name 
> {code}
> /**
>    * Configuration key to cache compound bloom filter blocks on write.
>    */
>   public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
>       "hfile.block.bloom.cacheonwrite";
> {code}
> Seems issue with entry in the xml file.
> We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message