hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5925) Issue with only using the old config param hbase.hstore.compactionThreshold but not the corresponding new one
Date Tue, 08 May 2012 19:39:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270756#comment-13270756
] 

Hadoop QA commented on HBASE-5925:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12526008/HBASE-5925.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1799//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1799//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1799//console

This message is automatically generated.
                
> Issue with only using the old config param hbase.hstore.compactionThreshold but not the
corresponding new one
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5925
>                 URL: https://issues.apache.org/jira/browse/HBASE-5925
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5925.patch
>
>
> One observation while going through the code:-
> In MemStoreFlusher constructor
> {code}
> this.blockingStoreFilesNumber =
>       conf.getInt("hbase.hstore.blockingStoreFiles", 7);
>     if (this.blockingStoreFilesNumber == -1) {
>       this.blockingStoreFilesNumber = 1 +
>         conf.getInt("hbase.hstore.compactionThreshold", 3);
>     }
> {code}
> Here as per the code if hbase.hstore.blockingStoreFiles is configured as -1, we are making
this value to be 1+ min files to compact
> But here we read the old config item only!
> Here also we need to read the new config 1st and if not there then the old one.. Is this
a miss?
> Like
> conf.getInt("hbase.hstore.compaction.min",
>          conf.getInt("hbase.hstore.compactionThreshold", 3))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message