hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
Date Sat, 26 May 2012 16:13:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284013#comment-13284013
] 

Zhihong Yu commented on HBASE-6071:
-----------------------------------

Thanks for the explanation, Igal.

I'd be happy to see the output from your patch running in 0.90.4 production.

FYI HBASE-4336 has changed source structure.

{code}
+          String message = String.format("Exception during try #%d (out of %d):", tries+1,
numRetries);
{code}
The above line is beyond 100 chars, please wrap the last parameter.
                
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-6071
>                 URL: https://issues.apache.org/jira/browse/HBASE-6071
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, ipc
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Igal Shilman
>            Priority: Minor
>              Labels: client, ipc
>         Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception
different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E])
adding a log message inside the catch block describing the exception type and details.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message