hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
Date Wed, 23 May 2012 09:43:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281485#comment-13281485
] 

Anoop Sam John commented on HBASE-5997:
---------------------------------------

I have gone through the flow for this API. I think there are some issues

1. In Store.rowAtOrBeforeFromStoreFile()
Gets StoreFile.Reader.getFirstKey()
In case of the half store file, this reader just calls the actual file reader. But this will
give the 1st key in the physical HFile(which is the 1st key in the bottom half file also).
The getFirstKey() is not overriden in the HalfStoreFileReader.

2. In Store.rowAtOrBeforeFromStoreFile() itself
HFileScanner scanner = r.getHFileReader().getScanner(true, true, false); 
In case of the half file, r will be the HalfStoreFileReader instance. But as we dont call
getScanner() on "r", always it will get the actual HFileScanner for the HFile( The delegator
in the HFileScanner instance in  HalfStoreFileReader ).

3. Other than these 2 issues we need to correct the issue with the seekBefore() API in the
HalfStoreFileReader.getScanner

I will address these issues and give a patch in some time.
                
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
>                 Key: HBASE-5997
>                 URL: https://issues.apache.org/jira/browse/HBASE-5997
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>         Attachments: HBASE-5997_0.94.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message