Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5F2A192E4 for ; Mon, 2 Apr 2012 18:03:47 +0000 (UTC) Received: (qmail 39151 invoked by uid 500); 2 Apr 2012 18:03:47 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 39113 invoked by uid 500); 2 Apr 2012 18:03:47 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 39105 invoked by uid 99); 2 Apr 2012 18:03:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Apr 2012 18:03:47 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Apr 2012 18:03:44 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D99C9354CB2 for ; Mon, 2 Apr 2012 18:03:23 +0000 (UTC) Date: Mon, 2 Apr 2012 18:03:23 +0000 (UTC) From: "stack (Resolved) (JIRA)" To: issues@hbase.apache.org Message-ID: <706898222.1615.1333389803902.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <599912265.3838.1333316788127.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (HBASE-5694) getRowsWithColumnsTs() in Thrift service handles timestamps incorrectly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-5694. -------------------------- Resolution: Fixed Fix Version/s: (was: 0.92.2) 0.94.0 Hadoop Flags: Reviewed Applied to 0.94 and to trunk. Thanks for the patch Wouter (I ran testthriftserver local and it passed). Doesn't look like thrift2 has similar code so passed on trying to apply the patch there. > getRowsWithColumnsTs() in Thrift service handles timestamps incorrectly > ----------------------------------------------------------------------- > > Key: HBASE-5694 > URL: https://issues.apache.org/jira/browse/HBASE-5694 > Project: HBase > Issue Type: Bug > Components: thrift > Affects Versions: 0.92.1 > Reporter: Wouter Bolsterlee > Fix For: 0.94.0 > > Attachments: HBASE-5694-trunk-20120402.patch, HBASE-5694.patch > > > The getRowsWithColumnsTs() method in the Thrift interface only applies the timestamp if columns are explicitly specified. However, this method also allows for columns to be unspecified (this is even used internally to implement e.g. getRows()). The cause of the bug is a minor scoping issue: the time range is set inside a wrong if statement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira