Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 10 Apr 2012 18:13:13 +0000 (UTC)
From: "Hudson (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <680513983.8641.1334081593314.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1660620339.18876.1310765939932.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4109) Hostname returned via reverse dns
 lookup contains trailing period if configured interface is not "default"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250899#comment-13250899 ] 

Hudson commented on HBASE-4109:
-------------------------------

Integrated in HBase-0.92 #366 (See [https://builds.apache.org/job/HBase-0.92/366/])
    HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311827)
HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311825)

     Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt

stack : 
Files : 
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Strings.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java

                
> Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4109
>                 URL: https://issues.apache.org/jira/browse/HBASE-4109
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.3
>            Reporter: Shrijeet Paliwal
>            Assignee: Shrijeet Paliwal
>             Fix For: 0.90.4
>
>         Attachments: 0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
>
>
> If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will 
> have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing. 
> It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC:  http://irbs.net/bog-4.9.5/bog47.html 
> We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.
> Quoting HRegionServer for example
> {code}
> String machineName = DNS.getDefaultHost(conf.get(
>         "hbase.regionserver.dns.interface", "default"), conf.get(
>         "hbase.regionserver.dns.nameserver", "default"));
> {code}
> This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here 
> http://search-hadoop.com/m/CANUA1qRCkQ1 
> We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira