Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E0E309D3E for ; Fri, 20 Apr 2012 15:33:04 +0000 (UTC) Received: (qmail 10890 invoked by uid 500); 20 Apr 2012 15:33:04 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 10839 invoked by uid 500); 20 Apr 2012 15:33:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 10830 invoked by uid 99); 20 Apr 2012 15:33:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Apr 2012 15:33:04 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Apr 2012 15:33:03 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 72CC942870 for ; Fri, 20 Apr 2012 15:32:43 +0000 (UTC) Date: Fri, 20 Apr 2012 15:32:43 +0000 (UTC) From: "Zhihong Yu (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <2013963921.10093.1334935963471.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <807147279.3203.1334781760718.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258313#comment-13258313 ] Zhihong Yu commented on HBASE-5824: ----------------------------------- In 0.94, client only needs to deal with RetriesExhaustedWithDetailsException whose only cause is a ConstraintException With Jimmy's patch, client needs to deal with RetriesExhaustedWithDetailsException (not subclass of DoNotRetryIOException) and ConstraintException (subclass of DoNotRetryIOException). This is because there're two execution paths for Put. I am afraid Benoit would have more to complain about in HBASE-5796 :-) > HRegion.incrementColumnValue is not used in trunk > ------------------------------------------------- > > Key: HBASE-5824 > URL: https://issues.apache.org/jira/browse/HBASE-5824 > Project: HBase > Issue Type: Bug > Reporter: Elliott Clark > Assignee: Jimmy Xiang > Fix For: 0.96.0 > > Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum > > > on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment. > My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called. > To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira