Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 1 Apr 2012 21:50:27 +0000 (UTC)
From: "Wouter Bolsterlee (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1821719966.3848.1333317027828.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <599912265.3838.1333316788127.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5694) getRowsWithColumnsTs function
 Thrift service incorrectly handles time range
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243873#comment-13243873 ] 

Wouter Bolsterlee commented on HBASE-5694:
------------------------------------------

For some reason, JIRA doesn't accept my patch file in the upload dialog. Here it is:


--- ThriftServer.java.orig	2012-04-01 23:41:16.881172406 +0200
+++ ThriftServer.java	2012-04-01 23:41:30.177238337 +0200
@@ -477,8 +477,8 @@
                 get.addColumn(famAndQf[0], famAndQf[1]);
               }
             }
-            get.setTimeRange(Long.MIN_VALUE, timestamp);
           }
+          get.setTimeRange(Long.MIN_VALUE, timestamp);
           gets.add(get);
         }
         Result[] result = table.get(gets);

                
> getRowsWithColumnsTs function Thrift service incorrectly handles time range
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-5694
>                 URL: https://issues.apache.org/jira/browse/HBASE-5694
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>    Affects Versions: 0.92.1
>            Reporter: Wouter Bolsterlee
>             Fix For: 0.92.2
>
>
> The getRowsWithColumnsTs() method in the Thrift interface only applies the timestamp if columns are explicitly specified. However, this method also allows for columns to be unspecified (this is even used internally to implement e.g. getRows()). The cause of the bug is a minor scoping issue: the time range is set inside a wrong if statement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira