Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B73DB9DB8 for ; Sun, 8 Apr 2012 03:07:15 +0000 (UTC) Received: (qmail 67837 invoked by uid 500); 8 Apr 2012 03:07:15 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 67789 invoked by uid 500); 8 Apr 2012 03:07:15 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 67778 invoked by uid 99); 8 Apr 2012 03:07:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Apr 2012 03:07:15 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Apr 2012 03:07:12 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id DFD1435D19E for ; Sun, 8 Apr 2012 03:06:51 +0000 (UTC) Date: Sun, 8 Apr 2012 03:06:51 +0000 (UTC) From: "Hudson (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <1224040062.462.1333854411972.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <2043595970.2932.1332434422335.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5618) SplitLogManager - prevent unnecessary attempts to resubmits MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249464#comment-13249464 ] Hudson commented on HBASE-5618: ------------------------------- Integrated in HBase-0.92 #362 (See [https://builds.apache.org/job/HBase-0.92/362/]) HBASE-5618 SplitLogManager - prevent unnecessary attempts to resubmits (Revision 1310921) Result = FAILURE stack : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java > SplitLogManager - prevent unnecessary attempts to resubmits > ----------------------------------------------------------- > > Key: HBASE-5618 > URL: https://issues.apache.org/jira/browse/HBASE-5618 > Project: HBase > Issue Type: Improvement > Components: wal, zookeeper > Reporter: Prakash Khemani > Assignee: Prakash Khemani > Fix For: 0.92.2, 0.94.0 > > Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch > > > Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time. > This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails. > Two changes should be made > (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped. > (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira