hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-5744) Thrift server metrics should be long instead of int
Date Sun, 08 Apr 2012 03:34:33 GMT

     [ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phabricator updated HBASE-5744:
-------------------------------

    Attachment: D2685.1.patch

mbautin requested code review of "[jira] [HBASE-5744] Thrift server metrics should be long
instead of int".
Reviewers: stack, sc, Kannan, JIRA

  As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead
of int everywhere. There is a bug where we truncate a nanosecond latency to int, which is
a problem with RPCs that take more than 2.147483647 seconds to process.

  This is a trunk diff. The 89-fb version of this diff is at D2679.

TEST PLAN
  TestThriftServer is updated to test for the failure case (an RPC is artificially made to
take 3 seconds). The new test case fails without the fix.

  Re-run all unit tests.

REVISION DETAIL
  https://reviews.facebook.net/D2685

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
  src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/6153/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
>                 Key: HBASE-5744
>                 URL: https://issues.apache.org/jira/browse/HBASE-5744
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>            Priority: Minor
>         Attachments: D2679.1.patch, D2685.1.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long
instead of int everywhere.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message