hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Yu (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered
Date Wed, 04 Apr 2012 18:21:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246539#comment-13246539
] 

Zhihong Yu commented on HBASE-5359:
-----------------------------------

{code}
     } catch (KeeperException e) {
       LOG.error("Error manipulating table " + Bytes.toString(tableName), e);
+    } finally {
+      // notify the waiting thread that we're done persisting the request
+      setPersist();
{code}
Should the setPersist() call be excluded from the case where KeeperException is encountered
?
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming
from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able
call AM.setRegionsToReopen so that the returned status shows no pending regions. It means
that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message