hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Yu (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (HBASE-5677) The master never does balance because duplicate openhandled the one region
Date Tue, 10 Apr 2012 03:59:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250443#comment-13250443
] 

Zhihong Yu edited comment on HBASE-5677 at 4/10/12 3:58 AM:
------------------------------------------------------------

Some comments about coding style:
{code}
+  //the master is running and it can provide service
+  public boolean isMasterAvailable() {
+	    return !isStopped() && isInitialized();
+  }
{code}
@Override is missing for the above method.
Please leave a space between // and the
Indentation for the return line should be 4 spaces. i.e. 'r' of return should be under 'b'
of public.
{code}
+      if(isAvailable) {
{code}
Please leave a space between if and left parenthesis.
{code}
+      throw new MasterNotRunningException();
{code}
You can create a new exception in place of MasterNotRunningException above.
                
      was (Author: zhihyu@ebaysf.com):
    Some comments about coding style:
{code}
+  //the master is running and it can provide service
+  public boolean isMasterAvailable() {
+	    return !isStopped() && isInitialized();
+  }
{code}
@Override is missing for the above method.
Please leave a space between // and the
Indentation for the return line should be 4 spaces. i.e. 'r' of return should be under 'b'
of public.
{code}
+      if(isAvailable) {
{code}
Please leave a space between if and left parenthesis.
{code}
+      throw new MasterNotRunningException();
{code}
You can create a new exception or provide cause to MasterNotRunningException.
                  
> The master never does balance because duplicate openhandled the one region
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5677
>                 URL: https://issues.apache.org/jira/browse/HBASE-5677
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.6
>         Environment: 0.90
>            Reporter: xufeng
>            Assignee: xufeng
>         Attachments: HBASE-5677-90-v1.patch, surefire-report_no_patched_v1.html, surefire-report_patched_v1.html
>
>
> If region be assigned When the master is doing initialization(before do processFailover),the
region will be duplicate openhandled.
> because the unassigned node in zookeeper will be handled again in AssignmentManager#processFailover()
> it cause the region in RIT,thus the master never does balance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message