hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5775) ZKUtil doesn't handle deleteRecurisively cleanly
Date Thu, 12 Apr 2012 21:31:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252861#comment-13252861
] 

Hadoop QA commented on HBASE-5775:
----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522467/java_HBASE-5775.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1499//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1499//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1499//console

This message is automatically generated.
                
> ZKUtil doesn't handle deleteRecurisively cleanly
> ------------------------------------------------
>
>                 Key: HBASE-5775
>                 URL: https://issues.apache.org/jira/browse/HBASE-5775
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.94.0
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.94.0, 0.96.0
>
>         Attachments: java_HBASE-5775.patch
>
>
> ZKUtil.deleteNodeRecursively()'s contract says that it handles deletion of the node and
all its children. However, nothing is mentioned as to what happens if the node you are attempting
to delete doesn't actually exist. Turns out, it throws a null pointer exception. I
> 'm proposing that we change the code s.t. it handles the case where the parent is already
gone and exits cleanly, rather than failing horribly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message