hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benoit Sigoure (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5796) Fix our abuse of IOE: see http://blog.tsunanet.net/2012/04/apache-hadoop-abuse-ioexception.html
Date Mon, 16 Apr 2012 01:17:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254477#comment-13254477
] 

Benoit Sigoure commented on HBASE-5796:
---------------------------------------

Just to be clear: the wrapping of Hadoop's {{IOException}} would be for a first pass, to make
sure everything HBase throws inherits from an {{HBaseException}}.  Ideally it would be better
to pick a more specific type of exception, but I expect this will be difficult in various
places where Hadoop suffers from the same problem and HBase itself has little to no visibility
into what the exception from Hadoop really means.

Also I'd recommend to actually use {{HBaseIOException}} as a base class name, and keep the
name {{HBaseException}} for when you guys switch to unchecked exceptions, if you're willing
to consider going down that route eventually (that'd require a separate JIRA issue).

Since HBase 0.96 is the "singularity", it's a good opportunity to break API compatibility.
 In this case, every release up to and including 0.94.x would have {{HBaseIOException}} as
the parent class, and in 0.96 the only thing you need to change is to make everything inherit
from {{HBaseException}} (which itself would inherit from {{RuntimeException}}).
                
> Fix our abuse of IOE: see http://blog.tsunanet.net/2012/04/apache-hadoop-abuse-ioexception.html
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5796
>                 URL: https://issues.apache.org/jira/browse/HBASE-5796
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>
> Lets make more context particular exceptions rather than throw IOEs everywhere.  See
BenoƮt's rant: http://blog.tsunanet.net/2012/04/apache-hadoop-abuse-ioexception.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message