hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5693) When creating a region, the master initializes it and creates a memstore within the master server
Date Sun, 01 Apr 2012 20:54:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243853#comment-13243853
] 

stack commented on HBASE-5693:
------------------------------

+1 on patch.  Its silly we initialize the region over on master on creation.

bq. CreateTableHandler isn't initializing the regions. Who will initialize them ?

The regionserver when its assigned a region.

bq. May be there is some thing more complex I didn't see, but at least all the unit tests
went well.

Nothing complex here.

Regards test on a real cluster, not necessary on a patch this small.  Unit tests run clusters
anyways.

Please make a patch that applies N and run it by hadoopqa.  Thanks.
                
> When creating a region, the master initializes it and creates a memstore within the master
server
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5693
>                 URL: https://issues.apache.org/jira/browse/HBASE-5693
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, regionserver
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 5693.v1.patch
>
>
> I didn't do a complete analysis, but the attached patch saves more than 0.25s for each
region creation and locally all the unit tests work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message