hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Jindal (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
Date Tue, 17 Apr 2012 11:12:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255475#comment-13255475
] 

Ashutosh Jindal commented on HBASE-5654:
----------------------------------------

@Jon
bq.add bounds checks? Result of integer multiplication cast to long in org.apache.hadoop.hbase.io.hfile.LruBlockCache.calculateOverhead(long,
long, int)
bq.Result of integer multiplication cast to long in org.apache.hadoop.hbase.regionserver.IncreasingToUpperBoundRegionSplitPolicy.getSizeToCheck(int)
I am not getting what kind of bound checks can be added here. Can u please take a look. 
                
> [findbugs] Address dodgy bugs
> -----------------------------
>
>                 Key: HBASE-5654
>                 URL: https://issues.apache.org/jira/browse/HBASE-5654
>             Project: HBase
>          Issue Type: Sub-task
>          Components: scripts
>    Affects Versions: 0.96.0
>            Reporter: Jonathan Hsieh
>            Assignee: Ashutosh Jindal
>              Labels: patch
>             Fix For: 0.96.0
>
>         Attachments: Hbase-5654.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE
> This may be broken down further.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message