hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5840) Open Region FAILED_OPEN doesn't clear the TaskMonitor Status, keeps showing the old status
Date Tue, 24 Apr 2012 18:15:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260774#comment-13260774
] 

stack commented on HBASE-5840:
------------------------------

Patch looks good.  Is it just moving all of this (too long) method into a try block and then
adding a finally that sets status.abort on the end (FYI, needs spacing around the operators
in the status.abort line so its same code style as rest of file).  Do you have to convert
the Exception to an IOE?  WHy is that?  What does this method let out?  IOEs only?  If so,
why we catch Exception?  In case its a non-checked exception?   On the test, it looks good
too but in the finally you might want to use the new HRegion.closeHRegion(region) to clean
up the wal log that gets made by the constructor.
                
> Open Region FAILED_OPEN doesn't clear the TaskMonitor Status, keeps showing the old status
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5840
>                 URL: https://issues.apache.org/jira/browse/HBASE-5840
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.94.0
>            Reporter: Gopinathan A
>            Assignee: rajeshbabu
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-5840.patch
>
>
> TaskMonitor Status will not be cleared in case Regions FAILED_OPEN. This will keeps showing
old status.
> This will miss leads the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message